I've built 6 or 7 tanks and have learned a couple thing along the way. Two or them were mounted with flanges that bolted to the frame - bad idea, they both cracked, maybe my welding, but that was a sign to me to abandon that mounting style. Every other tank I've made or used, I've mounted with straps and no problems.
Use a vent to the carb or air cleaner or better yet, to a OEM style charcoal cannister so you won't have it bubbling over on a hot day.
I always weld in a couple baffles to keep the sloshing down so your fuel sender isn't going nuts bouncing around.
I also run the pickup tube in from the top and tack it to the bottom of the tank so it doesn't move around (done before welding the tank ends on) and use an external filter.
As a final test, I pour some Varsol in it and pressurize the tank and roll it around to look for leaks.